[NODEBB] Help for my custom CSS

[DownPW]

The issue is closed @phenomlab

It’s a nodebb bug. Fixed in 2.5.3 milestone

[phenomlab]

@DownPW Yes, I saw that. Caused by regression from what I see.

Thanks

[phenomlab]

@DownPW said in [NODEBB] Help for my custom CSS:

JS code seems not working but…

Sorry, that should have been something like this (obviously modify the source and replacement)

$(document).ready(function() {
    $(window).on('action:ajaxify.end', function(data) {
        $(".row").find($(".fa")).removeClass('fa-fw fa-comments-o').addClass('fa-check-to-slot');
    });
});

[DownPW]

hi @phenomlab

on v2.x , I have user online widget in my home page and I can center the widget like this :

because we have a div by default on the widget

I can’t do the same on v3.x

Any idea how to get the same result ?

Thanks Dude

[phenomlab]

@DownPW I’d give the widget itself an id and then add custom css to that

div#onlineusers {
    left: 0;
    right: 0;
    margin: 0 auto;
    position: relative;
}

[DownPW]

@phenomlab

Yep, it’s a good idea thanks to you but I’d like to display it without div card-header and body like the first screen

[phenomlab]

@DownPW In that case, change the container code to

<div id="onlineusers">{{body}}</div>

And same CSS class

div#onlineusers {
    justify-content: center;
    display: flex;
}

Then add padding and margin to suit

[DownPW]

Perfect my friend

[DownPW]

Hello mark

I wanted for test purposes, to put the welcome message in the Brand menu in the header widget.

I commented in the footer widget the corresponding code then I added it in my brand header widget:

<span id="thisuser" class="getUsername">, &nbsp;<a href="/me"><span class="username">DownPW</span></a></span>

I commented out the old CSS to add the new:

/* Welcome Message Username on Header */
span#thisuser {
     margin-top: 0.7rem;
     margin-left: 2px;
     margin-right:-2px;
     font-size: .875rem;
     line-height: 1.4rem;
     font-weight: 500;
}

So far everything is fine, the result is correct :

But as soon as I select links in the left sidebar (home, recent, etc …), the message is added and displayed as many times as I select a link .

Did I miss something or do you have an idea to solve this bug?

Thanks my friend

[phenomlab]

@DownPW sorry for the delay. That is being caused by ajax which is adding another element each time data is being called. I’d need to see the entire code block where you are adding this to confirm, but from the video you provided, that’s typically caused by the above.

You only need that specific function to run once at page load - it’s running each time data is being requested which explains the additions.

[DownPW]

it’s just the brand HTML header widget, just add this code to him

<span id="thisuser" class="getUsername">,  <a href="/me"><span class="username">DownPW</span></a></span>]

What do you want ? The HTML header widget on welcome message JS code ?

EDIT : All code in PM

[phenomlab]

@DownPW thanks. Can you try a theory for me and change that code so it looks like the below

<span id="thisuserbrand" class="getUsername">,  <a href="/me"><span class="username">DownPW</span></a></span>

I expect this to return nothing, which will prove my theory around the Ajax calls.

[DownPW]

Nope @phenomlab

Same things, same problem

[phenomlab]

@DownPW then the problem isn’t the existing function. That ID I provided doesn’t exist anywhere and isn’t tied to any elements so should never trigger.

[DownPW]

oups don’t know why I have used this code, replace by :

<div class="getUsername">, <a href="/me"><span class="username"></span></a></div>

But same problem

[phenomlab]

@DownPW did you remove the original line from the footer before placing it in the brand header?

[DownPW]

remove no, but commented like this

<!-- <span id="thisuser" class="getUsername">,  <a href="/me"><span class="username">DownPW</span></a></span> -->

EDIT: test with remove = same

[phenomlab]

@DownPW can you send me the footer function your are using. I’m 100% certain this is being caused by the ajax call.

[phenomlab]

@DownPW can you change the top line of this function from

$(window).on('action:ajaxify.end', function (data) {

To

$(document).ready() {

Save and let me know if this changes anything. The theory here is that the Ajax call in the top line causes the prepend to be executed multiple times

[DownPW]

the code doesn’t work with this