[NODEBB] CSS Style Sheets SelectBox

[DownPW]

@phenomlab Of course it is a very good basis for work.

[phenomlab]

@downpw Small modification to address the default theme icon bug (displayed white when focus lost, when it should be black)

// Bugfix theme switcher button when dropdown / Focus / Not focus
$(window).on('action:ajaxify.end', function(data) {
    var whichTheme = localStorage.getItem("theme");
    if (whichTheme === '') {
        // Assume default theme and set icon color to #000000
        $("#switcher i").css("color", "#000000");
    }
    if (whichTheme !== '') {
        // Assume color theme and set icon color to #ffffff
        $("#switcher i").css("color", "#ffffff");
    }
    // Detect if the theme dropdown has been clicked. If it has, change the color to #000000
    $("#switcher").on("click", function() {
        $("#switcher i").css("color", "#000000");
    });
    // Detect if the theme dropdown has lost focus (clicked something else). If it has, change the color to #FFFFFF
    $("#switcher").on("focusout", function() {
        $("#switcher i").css("color", "#ffffff");
    });
});

Active now, and should also address the other bug you mentioned.

[DownPW]

@phenomlab

I have tested but sorry it’s the same problem.

[phenomlab]

@downpw Can you reload the page and try again.

[DownPW]

Yeah i delete cache and Ctrl + F5

The problem come when I don’t click on fa-fw but background.

Like this :

On fa-fw = No problem

[phenomlab]

@downpw Ok, do the default theme issue is fixed, but you still see the white icon when clicking the background and not the icon itself ?

[phenomlab]

@downpw Try now

[DownPW]

nope it’s the same even on fa-fw and default theme

but as you are connected you have to see it.

[phenomlab]

@downpw Right. I think I finally have this working

I’ve added this into your global CSS - don’t delete it

.themeon {
    color: #000000 !important;
}
.themeoff {
    color: #ffffff !important;
}

Final modified JS

// Bugfix theme switcher button when dropdown / Focus / Not focus
	$(document).ready(function () {
	// First, detect which theme is in use
    var whichTheme = localStorage.getItem("theme");
    // Is the target dropdown expanded ? Use aria-expanded for this as it populates into the DOM on change making it easier to work with. 
    // If it is expanded, then we set the icon to WHITE with CSS class "themeon"
      if ($('#theme_dropdown').attr('aria-expanded') === "true") {
         $("#switcher i").addClass("themeon");
      }
    // If it is collapsed, then we set the icon to BLACK with CSS class "themeoff"
      if ($('#theme_dropdown').attr('aria-expanded') === "false") {
         $("#switcher i").addClass("themeoff");
      }
      // If we are using the default theme, deploy CSS "themeoff" and set the icon to BLACK
          if (whichTheme === '') {
      // If no other matches, assume the default theme, deploy CSS "themeoff" and set the icon to BLACK
         $("#switcher i").removeClass("themeoff");
    }
});

According to my testing, this works

[DownPW]

clear and simple explanations.
Perfect

I don’t know if I should say this but… I love you ha ha

[phenomlab]

@downpw Some last changes to address small bugs. The below CSS has been added

/* DO NOT DELETE THESE LINES */
[aria-expanded="true"] a #ticon {
    color: #000000;
}

.themeon {
    color: #ffffff !important;
}
.themeoff {
    color: #000000 !important;
}

And also to the mobile block

/* DO NOT DELETE THESE LINES */
[aria-expanded="true"] a #ticon {
    color: #ffffff;
}
.themeoff {
    color: #ffffff !important;
}

Finally, a new function

// When hovering over the #switcher element, target the i class and add 'themeoff'
  $(document).on('mouseenter','#switcher', function() {
		$('#switcher i').addClass("themeoff");
});
// When leaving the however state, target the i class and remove 'themeoff'
  $(document).on('mouseleave','#switcher', function() {
		$('#switcher i').removeClass("themeoff");
});

This block should be deleted

/*
// Bugfix theme switcher button when dropdown / Focus / Not focus
	$(document).ready(function () {
	// First, detect which theme is in use
	// Tout d'abord, on détecte quel thème est utilisé
    var whichTheme = localStorage.getItem("theme");
    // Is the target dropdown expanded ? Use aria-expanded for this as it populates into the DOM on change making it easier to work with. 
    // If it is expanded, then we set the icon to WHITE with CSS  class "themeon"
    // On utilise "aria-expanded" pour savoir si le menu déroulant est actif/dévelopé car la variable se remplit dans le DOM en cas de changement, ce qui facilite le travail avec.
    // Si le menu est actif/dévelopé, on définit l'icône en BLANC avec la classe CSS "themeon"
      if ($('#theme_dropdown').attr('aria-expanded') === "true") {
         $("#switcher i").addClass("themeon");
      }
    // If it is collapsed, then we set the icon to BLACK with CSS  class "themeoff"
    // S'il est réduit/non actif, nous définissons l'icône sur NOIR avec la classe CSS "themeoff"
      if ($('#theme_dropdown').attr('aria-expanded') === "false") {
          console.log("Theme selector is not active");
         $("#switcher i").addClass("themeoff");
      }
      // If we are using the default theme, deploy CSS "themeoff" and set the icon to BLACK
      // Si on utilise le thème par défaut, on utilise le CSS "themeoff" et on définit l'icône sur NOIR
          if (whichTheme === '') {
      // If no other matches, assume the default theme, deploy CSS  "themeoff" and set the icon to BLACK
      // Si rien ne correspond, on utilise le thème par défaut, on utilise le CSS "themeoff" et on définit l'icône sur NOIR
         $("#switcher i").removeClass("themeoff");
    }
});
*/

[DownPW]

@phenomlab

It’s possible to add a reload at the end of the script ?

Because, I just saw this:

if certain CSSS variables are declared in one theme and not in the other, when I Switch themes, the CSS was applied but not correctly. If i refresh it’s OK.

I seem to have 2 solutions:

• Declare all variables in each theme even if they are not used in others (with or without !important)

• Reload the page after selecting a theme.

Or maybe you have another solution.

[phenomlab]

@downpw in most cases, the best way to handle this is to strip one CSS file before you add the other. However, as your CSS file is actually an extension of the main theme (in the sense that stock theme provides default variables and your custom theme overrides these), this will not work as the required CSS for the site to run properly will be missing.

Reloading the site will work, but it’s not really the way to go as all the resources will need to be loaded again, and this defeats the purpose of jQuery in the sense that it is Ajax backed meaning the DOM should already contain the targets to be changed.

If reloading solves the issue, then ok. Admittedly, we have to do this with the default theme when selected to ensure we strip all previously loaded CSS from the custom themes.

[phenomlab]

@DownPW as discussed in PM

Seems to have been solved with the new JS code that you added allowing the version CSS file change!!

Cache problem therefore with the JS of the Switcher theme

Based on this, I will close this thread and reference
https://sudonix.com/topic/207/nodebb-help-for-my-custom-css/27